Skip to content

Conversation

@ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Dec 31, 2025

What are the relevant tickets?

https://github.com/mitodl/hq/issues/9737

Description (What does it do?)

The Learning Resource Card has been introduced in the TipTap editor to improve the authoring experience and enable richer, reusable learning content. However, the current implementation is missing key interactive features that already exist elsewhere in the platform—specifically in the MIT Learn Search and Dashboard experiences.

Screenshots (if appropriate):

Screen.Recording.2025-12-31.at.4.10.01.PM.mov

How can this be tested?

  • You need to embed the following url http://open.odl.local:8062/search?resource=<resource_id> and it will insert the course card inside the editor
  • After the above step, you need to click on the course card it will open the drawer from the right
  • You need to click on bookmark icon on the course card it will open the user list.

Additional Context

@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/resource-card-drawer branch from afbcb4a to b83b011 Compare December 31, 2025 10:59
@ahtesham-quraish ahtesham-quraish added the Needs Review An open Pull Request that is ready for review label Dec 31, 2025
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

OpenAPI Changes

Show/hide No detectable change.

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

@ahtesham-quraish
Copy link
Contributor Author

@jonkafton I have used the ResourceCard for the learning resource card you can check now

Base automatically changed from ahtesham/editor-component-migration to main January 6, 2026 16:31
Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahtesham-quraish can you pls resolve conflicts with main as that should drastically reduce the diff (it includes the changes from #2833).

It's not ideal for the editor to live in the main workspace as it's quite pollutant to the dependencies and; as an editor, is not Learn-specific. In practical terms this does solve the immediate import hierarchy concern. See https://github.com/mitodl/mit-learn/blob/main/docs/rfcs/0006-front-end-component-structure.md (predates Next.js so will be outdated in places). Let's look towards (not now, later) a mechanism to pass custom extensions into the editor so that apps would need to define them locally. Dependency injection or perhaps a registry. We'll want to move towards the editor existing as a self-contained reusable component. Comment for #2833 though!

@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/resource-card-drawer branch from e0929e1 to dd7ec6a Compare January 7, 2026 07:09
@ahtesham-quraish
Copy link
Contributor Author

@jonkafton I have rebased the PR

Dependency injection or perhaps a registry. We'll want to move towards the editor existing as a self-contained reusable component.

We can work on this this sounds ok to me.

Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One issue to ideally fix here (though it will go away with the SSR updates) is that the resource card is highlighted (red border) when active in the detail view. These should behave the same as resource cards elsewhere (check the search page).

We have lost the insert menu item at some point. The ability to paste a URL to insert a resource card is certainly a nice-to-have, but editors have no way of knowing about this functionality without documentation.

@Ferdi
Copy link

Ferdi commented Jan 7, 2026

We have lost the insert menu item at some point. The ability to paste a URL to insert a resource card is certainly a nice-to-have, but editors have no way of knowing about this functionality without documentation.

That is a good point. We should find a way so we can keep the item in the menu as optional. When users click the item ..

Screenshot 2026-01-07 at 12 17 56 PM

@ahtesham-quraish
Copy link
Contributor Author

We have lost the insert menu item at some point. The ability to paste a URL to insert a resource card is certainly a nice-to-have, but editors have no way of knowing about this functionality without documentation.

That is a good point. We should find a way so we can keep the item in the menu as optional. When users click the item ..

Screenshot 2026-01-07 at 12 17 56 PM

Ok I will create new PR to bring that option back

@ahtesham-quraish ahtesham-quraish merged commit 420f6e0 into main Jan 8, 2026
13 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/resource-card-drawer branch January 8, 2026 15:00
@odlbot odlbot mentioned this pull request Jan 8, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants