-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add course detail in resource card #2834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afbcb4a to
b83b011
Compare
OpenAPI ChangesShow/hide No detectable change.Unexpected changes? Ensure your branch is up-to-date with |
|
@jonkafton I have used the ResourceCard for the learning resource card you can check now |
jonkafton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahtesham-quraish can you pls resolve conflicts with main as that should drastically reduce the diff (it includes the changes from #2833).
It's not ideal for the editor to live in the main workspace as it's quite pollutant to the dependencies and; as an editor, is not Learn-specific. In practical terms this does solve the immediate import hierarchy concern. See https://github.com/mitodl/mit-learn/blob/main/docs/rfcs/0006-front-end-component-structure.md (predates Next.js so will be outdated in places). Let's look towards (not now, later) a mechanism to pass custom extensions into the editor so that apps would need to define them locally. Dependency injection or perhaps a registry. We'll want to move towards the editor existing as a self-contained reusable component. Comment for #2833 though!
e0929e1 to
dd7ec6a
Compare
|
@jonkafton I have rebased the PR
We can work on this this sounds ok to me. |
jonkafton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One issue to ideally fix here (though it will go away with the SSR updates) is that the resource card is highlighted (red border) when active in the detail view. These should behave the same as resource cards elsewhere (check the search page).
We have lost the insert menu item at some point. The ability to paste a URL to insert a resource card is certainly a nice-to-have, but editors have no way of knowing about this functionality without documentation.


What are the relevant tickets?
https://github.com/mitodl/hq/issues/9737
Description (What does it do?)
The Learning Resource Card has been introduced in the TipTap editor to improve the authoring experience and enable richer, reusable learning content. However, the current implementation is missing key interactive features that already exist elsewhere in the platform—specifically in the MIT Learn Search and Dashboard experiences.
Screenshots (if appropriate):
Screen.Recording.2025-12-31.at.4.10.01.PM.mov
How can this be tested?
http://open.odl.local:8062/search?resource=<resource_id>and it will insert the course card inside the editorAdditional Context