fix: correct ability executors creation#11
Open
rubinkrief wants to merge 1 commit into
Open
Conversation
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
create_linux_abilityandcreate_windows_abilityfunctions inmcp_server.pyproduce abilities with swappednameandplatformvalues in the executor object. This causes the Caldera agent to silently skip all abilities created through the MCP plugin, since the agent cannot match the executor to its platform.These fixes swapped between the name and the platform values in the executor object created in both aforementioned functions and now the abilities can be executed in the operation run.
Closes #10
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: