Replace hardcoded Caldera credentials with env vars#13
Open
deacon-mp wants to merge 1 commit into
Open
Conversation
The API key and URL were hardcoded in mcp_server.py. This change reads them from CALDERA_API_KEY and CALDERA_URL environment variables, falling back to the previous defaults for backward compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADMIN123) and URL inapp/mcp_server.pywithos.environ.get()callsCALDERA_API_KEYandCALDERA_URLenvironment variablesMotivation
Hardcoded credentials in source code pose a security risk, especially in public repositories. This change allows users to configure credentials via environment variables without modifying the source, while maintaining backward compatibility with the existing defaults.
Test plan
CALDERA_API_KEYandCALDERA_URLfrom the environment when set🤖 Generated with Claude Code