Fix: Add missing parsers and cleanup parameters to MCP ability tools#20
Open
KirillM1 wants to merge 1 commit into
Open
Fix: Add missing parsers and cleanup parameters to MCP ability tools#20KirillM1 wants to merge 1 commit into
KirillM1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing
parsersandcleanupparameters to thecreate_windows_abilityandcreate_linux_abilitytools in the MCP server.Previously, these fields were hardcoded to empty lists in the executor payload. This prevented the MCP client (and the LLM using it) from defining critical cleanup commands (leaving IOCs behind) or adding output parsers (missing facts) when generating Caldera abilities.
This change updates the function signatures, docstrings, and executor payload mappings to accept and pass these lists correctly.
Closes #19
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
mcp_server.py.create_linux_abilityandcreate_windows_abilitytools via an MCP client, explicitly passing a mock parser and a cleanup command (e.g.,rm -f /tmp/dropped_payload).parsersandcleanuplists within the executor object correctly contained the passed values, rather than defaulting to empty lists.Checklist: