-
Notifications
You must be signed in to change notification settings - Fork 11
backend: add integration tests #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ure/integration-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code yet
Will do once we have the build status figured out
.github/workflows/backend-tests.yml
Outdated
| PORT: ${{ secrets.PORT }} | ||
| HUDDLE_PROJECT_ID: ${{ secrets.HUDDLE_PROJECT_ID }} | ||
| HUDDLE_API_KEY: ${{ secrets.HUDDLE_API_KEY }} | ||
| PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this to LIT_WALLET_PRIVATE_LEY
| PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }} | |
| LIT_WALLET_PRIVATE_LEY: ${{ secrets.LIT_WALLET_PRIVATE_LEY }} |
👷 Deploy Preview for khoj-alpha processing.
|
|
@copilot make changes so that test related to sign protocol get ignored while running test |
|
@ayush4345 I've opened a new pull request, #187, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: ayush4345 <[email protected]>
backend: configure Jest to skip Sign Protocol tests
…al-parth/Khoj into feature/integration-testing
…al-parth/Khoj into feature/integration-testing
- Remove built-in cache from setup-node to prevent yarn cache path issues - Add explicit npm cache directory creation step - Add actions/cache@v3 with proper npm paths and cache keys - Update install step to conditionally use npm ci or npm install - Set node-version explicitly to '24' instead of matrix variable - Apply changes to both test and integration-test jobs Fixes CI job 57226870056 failure: "Some specified paths were not resolved, unable to cache dependencies" Co-authored-by: ayush4345 <[email protected]>
…s-to-use-npm Fix backend-tests workflow npm caching to prevent "paths not resolved" error
…al-parth/Khoj into feature/integration-testing
Co-authored-by: ayush4345 <[email protected]>
Co-authored-by: ayush4345 <[email protected]>
Co-authored-by: ayush4345 <[email protected]>
Add CI-only Jest mock for sign-protocol service
…al-parth/Khoj into feature/integration-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have all these dependencies and scripts added but not no tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont see the need to alter this file. I wouldn't want to alter this for tests to work - quite sensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't have a separate file for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are actually not integration tests
They are mostly just unit tests checking each API. Integration tests are one that test everything. In our case everything happening from the UI interaction via the API, and contract should all be tested.
This is also good to have but these are not integration tests.
Plus, we can't have response to be either 200 or 400/500 as it in most of these tests. We should mock the services and then expect the exact response - both 200 and 400/500 in separate tests. These will still be unit tests however.
No description provided.