Fix immediate undo resetting to 'loading...' text#99
Open
edemaine wants to merge 1 commit intomizzao:masterfrom
Open
Fix immediate undo resetting to 'loading...' text#99edemaine wants to merge 1 commit intomizzao:masterfrom
edemaine wants to merge 1 commit intomizzao:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mixes a bug in CodeMirror where, after the initial text loads and replaced 'loading...', pressing ctrl-Z undoes that change and goes back to the 'loading...' text. This bug was mentioned in:
The solution was to set the undo stack to size 0 before making the (first) change, then restoring the undo stack size.