Skip to content

Conversation

@NorthIsUp
Copy link

No description provided.

@mjpieters
Copy link
Owner

I really need to move away from Azure and put the pipelines here, to help visibility.

You'll need to at least address the lint failure:

/home/vsts/work/1/s/src/aiolimiter/leakybucket.py:129:94: B950 line too long (93 > 80 characters)

I'd also like to see a test for this change, would you be able to provide one?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7b9407d) to head (dafbc8b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #305   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           81        84    +3     
  Branches        10        10           
=========================================
+ Hits            81        84    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@mjpieters
Copy link
Owner

I keep going back and forth on this, as I am not convinced that this information is all that useful. In addition, I think the naming here is wrong; the accessor returns the minimum wait time; if there are other tasks waiting the actual time will be longer, and calculating a better estimate is going to be quite a bit harder.

What is your use case for this?

There are some other nitpicks with some of the details of the PR but those can wait until we have figured out the fundamental question, that is, do we really need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants