Skip to content

Conversation

@cl3wis
Copy link
Contributor

@cl3wis cl3wis commented Jul 16, 2018

WRT Issue #35

What's done:

  • removes default config file set in argparser
  • adds method in Config for getting existing config file if arg isn't set

What remains to be done

  • support $XDG_DATA_HOME and $XDG_CACHE_HOME
  • test (unit tests preferably) the various possible scenarios, if it breaks existing config setups, etc

- removes default config file set in argparser
- adds method in Config for getting existing config file if arg isn't set
@mjpost
Copy link
Owner

mjpost commented Jul 26, 2018

This looks good to me. Do you want me to wait for you to do the other items on the TODO list?

@cl3wis
Copy link
Contributor Author

cl3wis commented Jul 27, 2018 via email

@mjpost
Copy link
Owner

mjpost commented Aug 1, 2018

I'll probably just merge this in tomorrow, unless you want another weekend?

@cl3wis
Copy link
Contributor Author

cl3wis commented Aug 8, 2018

I guess the data directory can be set easily enough by the user, and I'm not sure that the XDG-specified ~/.local/share/bibsearch/papers offers any significant advantage over ~/.bibsearch/papers, so... maybe it's done?

@davvil
Copy link
Collaborator

davvil commented Dec 6, 2018

This a ping for @mjpost and myself (@davvil) to merge this. Somehow I thought it was already taken care of...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants