This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Add migration to Intercom #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fodoj
suggested changes
Sep 6, 2017
apps/web/config/routes.rb
Outdated
| @@ -3,6 +3,8 @@ | |||
|
|
|||
| get '/', to: 'folders#index' | |||
|
|
|||
| post '/tickets/:id/export', to: 'tickets#export', as: :export_ticket | |||
There was a problem hiding this comment.
There are rails-like resource routes http://hanamirb.org/guides/routing/restful-resources/
| ticket = TicketRepository.new.find(params[:id]) | ||
| ticket.migrate | ||
| redirect_to '/' | ||
| end |
There was a problem hiding this comment.
Some notification like "Exported started" would be great
lib/mkdev_hanami/entities/ticket.rb
Outdated
|
|
||
| def messages | ||
| MessageRepository.new.by_ticket(id) | ||
| end |
There was a problem hiding this comment.
Looks like associations. There is support of assoications in Hanami: http://hanamirb.org/guides/1.0/models/associations/
Gemfile
Outdated
| @@ -7,6 +7,8 @@ gem 'hanami-bootstrap' | |||
| gem 'omniauth-google-oauth2' | |||
| gem 'warden' | |||
| gem 'groovehq' | |||
| gem 'intercom' | |||
| gem 'sucker_punch', '~> 2.0' | |||
| require 'intercom' | ||
|
|
||
| module Services | ||
| class Intercom |
There was a problem hiding this comment.
Is it recommended way to implement service objects? Ain't Hanami Entities better choice?
There was a problem hiding this comment.
Also search for interactors here https://discourse.hanamirb.org/t/hanami-2-0-ideas/306/2
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.