Reset index before returning dataframe #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
reviewed
Feb 11, 2025
| @@ -110,7 +110,9 @@ def _read_file_content(self, encoding_format: str, file: Path) -> pd.DataFrame: | |||
| return pd.read_json(file, lines=True) | |||
| elif encoding_format == EncodingFormat.PARQUET: | |||
| try: | |||
| return pd.read_parquet(file) | |||
| df = pd.read_parquet(file) | |||
| df.reset_index(inplace=True) | |||
There was a problem hiding this comment.
Either:
df.reset_index(inplace=True)or
df = df.reset_index()because we use this style a lot
marcenacp
reviewed
Feb 11, 2025
| @@ -110,7 +110,9 @@ def _read_file_content(self, encoding_format: str, file: Path) -> pd.DataFrame: | |||
| return pd.read_json(file, lines=True) | |||
| elif encoding_format == EncodingFormat.PARQUET: | |||
| try: | |||
| return pd.read_parquet(file) | |||
| df = pd.read_parquet(file) | |||
There was a problem hiding this comment.
Maybe you can add a comment saying something like: Sometimes the author already set an index in Parquet, so we want to reset it to always have the same format
There was a problem hiding this comment.
Done, thanks! Also updated the PR description with more context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when processing parquet-based datasets using pandas, the index column is treated as the dataframe's index, even though it should be another column. This results in an error at the column lookup step in the ReadFields operation:
croissant/python/mlcroissant/mlcroissant/_src/operation_graph/operations/field.py
Line 219 in f2d0cfd
Example dataset where this happens: https://huggingface.co/datasets/rag-datasets/rag-mini-wikipedia