[URGENT] pinning version of dependency for editor #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benjelloun
approved these changes
Feb 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you might have noticed the HF space that holds the croissant editor was out of date and is now completely broken. I've been trying to figure out why - it's a dependency issue with streamlit-nested-layout, but it's impossible to replicate in local tests in the docker container or even in venvs.
locally, version 0.1.2 of the library has a similar error with up-to-date streamlit versions, and I'm thinking that the HF space (when it creates the container) has some sort of caching that means it's loading 0.1.2 rather than 0.1.4 (which works as intended).
So, this PR is just a pin in requirements.txt and an instruction to not cache in Dockerfile to maybe avoid that problem. Locally this works, but it seems it's a dice roll on whether it will work on HF.
NOTE - commits to editor files here do not change the HF space.
LONG TERM - should remove dependency on streamlit-nested-layout, which is serviced by two people and doesn't offer tons of value. I guess we might move away from streamlit anyway.