Support multi-venv workflows by adding recursive ADR opt-out per dependency#916
Draft
arjunsuresh with Copilot wants to merge 5 commits into
Draft
Support multi-venv workflows by adding recursive ADR opt-out per dependency#916arjunsuresh with Copilot wants to merge 5 commits into
arjunsuresh with Copilot wants to merge 5 commits into
Conversation
Agent-Logs-Url: https://github.com/mlcommons/mlperf-automations/sessions/49fb0963-9e55-4d8a-a616-93fa393f45cc Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mlcommons/mlperf-automations/sessions/49fb0963-9e55-4d8a-a616-93fa393f45cc Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
…tions Agent-Logs-Url: https://github.com/mlcommons/mlperf-automations/sessions/49fb0963-9e55-4d8a-a616-93fa393f45cc Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for multiple Python virtual environments in MLC workflow
Support multi-venv workflows by adding recursive ADR opt-out per dependency
Apr 20, 2026
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.📁 File Hygiene & Output Handling
📝 Comments & Communication
Fixes #,Related to #, etc.)adrcurrently propagates Python dependency overrides through the full workflow tree, which makes mixed-environment flows (e.g., calibration in a different venv) brittle.This change introduces a per-dependency escape hatch so selected deps can stay local even when parent
adroverrides are present.Core behavior change (
automation/script/module.py)skip_add_deps_recursive: true.adr/add_deps_recursive).Applied to Python venv install path (
script/install-python-venv/meta.yaml)get,python,-virtualdependency as non-recursive-overrideable to prevent global Python ADR leakage into venv creation.Docs + coverage
skip_add_deps_recursivein script automation README dependency modifiers.test-mlc-script-features.ymlwith a focused workflow test that validates recursive ADR does not override deps opting out.🛡️ Safety & Security