Skip to content

get-tool-intel-pin: add path.# variation for custom installation path#956

Open
YasirKhokhar wants to merge 4 commits into
mlcommons:devfrom
YasirKhokhar:dev
Open

get-tool-intel-pin: add path.# variation for custom installation path#956
YasirKhokhar wants to merge 4 commits into
mlcommons:devfrom
YasirKhokhar:dev

Conversation

@YasirKhokhar

Copy link
Copy Markdown

What
Adds a path.# variation to get-tool-intel-pin to support specifying a custom PIN tool installation directory via --pintool_dir= CLI flag.

Why
Without this variation, the cache key for get-tool-intel-pin does not include the installation path, so passing a custom path would always hit the cached entry from the default installation effectively ignoring the custom path.

The path.# variation ensures that each unique path gets its own cache entry, making custom PIN tool installations work correctly and cache-safely.

@YasirKhokhar YasirKhokhar requested a review from a team as a code owner May 11, 2026 23:09
@github-actions

Copy link
Copy Markdown
Contributor

MLCommons CLA bot:
Thank you very much for your submission; we really appreciate it. Before we can accept your contribution,
we ask that you sign the MLCommons CLA (Apache 2). Please submit your GitHub ID to our onboarding form to initiate
authorization. If you are from a MLCommons member organization, we will request that you be added to the CLA.
If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact
support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
@YasirKhokhar
You can retrigger this bot by commenting recheck in this Pull Request

@arjunsuresh

Copy link
Copy Markdown
Collaborator

Looks good @YasirKhokhar Can you please change the commit user to the GitHub user with AMD email? Merge to Mlcommons requires CLA signing.

@YasirKhokhar

Copy link
Copy Markdown
Author

recheck

@arjunsuresh

Copy link
Copy Markdown
Collaborator

@YasirKhokhar can you please change the commit author email to your AMD email address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants