Create actions from notification/report for message swipes - #2947
Merged
Conversation
Add a quickSwipes overload that accepts an InboxNotification, Message and Report plus configuration so swipe actions can be resolved in the context of a notification or report. Implement ActionSeed.createAction(notification:message:report:) to prefer notification- or report-specific actions and fall back to message actions. Update MessageView to use the new API and add the interactionBar_reply setting; remove the old trailingSwipes helper and an unused import. This lets message rows surface the correct actions when shown as inbox notifications or reports.
aqylbermeshtech
requested review from
EricBAndrews and
Sjmarf
and removed request for
a team
August 30, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
MessageViewshould use same swipe action configuration as replies #2925Description
MessageViewhardcoded a single trailing "mark read" swipe instead of reading the inbox swipe configuration, so private message rows ignored Settings → Inbox → Swipe Actions. It now uses the sameReplyBarConfiguration(interactionBar_reply) thatReplyViewuses.Implementation Notes
Adds a
quickSwipes(notification:message:report:configuration:)overload alongside the existing one inContextMenu+InboxNotification.swift, plus a privateActionSeed.createAction(notification:message:report:)helper that resolves each seed against notification → report → message — the same ordercontextMenu(notification:message:report:)already uses in that file.Seeds that don't apply to messages (
upvote,downvote,save) returnniland drop out viacompactMap, so only the applicable configured actions render.With the default config, message rows now show Reply where they previously showed Mark Read. Agreed as the desired behavior in #2925.