fix: LoggedModels do not show up when using Group permissions #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use-case where we do not issue any user rights and do authorization solely based on group permissions. (Our fallback permission is NO_PERMISSIONS so users all use the fallback). In such case the after_request hook filters out all the LoggedModels since it fetches all experiments based on user rights "store.list_experiment_permissions(username)"
I believe this should take into account the effective permissions of the user(including group) and not just user permissions. That is why I have modified it to use effective_experiment_permission(model.experiment_id, username).permission.can_read
I haven't adjusted the tests yet they assert store.list_experiment_permissions(username) to be called once.