Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise if mx < k. Handle mx = k separately. #113

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

mlondschien
Copy link
Owner

No description provided.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.79%. Comparing base (4e27ae5) to head (ddd3a26).
Report is 1 commits behind head on main.

Files Patch % Lines
ivmodels/models/kclass.py 83.33% 1 Missing ⚠️
ivmodels/tests/likelihood_ratio.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   94.85%   94.79%   -0.07%     
==========================================
  Files          37       37              
  Lines        2313     2323      +10     
==========================================
+ Hits         2194     2202       +8     
- Misses        119      121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlondschien mlondschien enabled auto-merge (squash) August 23, 2024 08:30
@mlondschien mlondschien merged commit 1ccd709 into main Aug 23, 2024
6 of 8 checks passed
@mlondschien mlondschien deleted the raise-if-k-smaller-than-mx branch August 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant