Correctly display f-test, j-test in summary.

CHANGELOG.rst

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+0.5.2 - 2024-10-03
+------------------
+
+**Bug fixes:**
+
+- The :class:`~ivmodels.summary.Summary` now correctly includes the rank and J test results.
+
 0.5.1 - 2024-09-16
 ------------------
 

ivmodels/summary.py

@@ -199,14 +199,14 @@ def fit(self, X, y, Z=None, C=None, *args, **kwargs):
         self.f_statistic_, self.f_p_value_ = (
             tests.rank_test(Z, X, C=C, fit_intercept=fit_intercept)
             if self.kclass._is_iv_estimator()
-            else None
-        ), None
+            else (None, None)
+        )
 
         self.j_statistic_, self.j_p_value_ = (
             tests.j_test(Z, X, y=y, C=C, fit_intercept=fit_intercept)
             if self.kclass._is_iv_estimator() and Z.shape[1] > X.shape[1]
-            else None
-        ), None
+            else (None, None)
+        )
 
         return self
 

pyproject.toml

@@ -5,7 +5,7 @@ requires = ['setuptools', 'setuptools-scm', 'wheel']
 name = "ivmodels"
 description = "IV Models"
 readme = "README.md"
-version = "0.5.1"
+version = "0.5.2"
 requires-python = ">=3.7"
 authors = [
     { name = "Malte Londschien", email = "[email protected]" },

tests/test_summary.py

@@ -44,6 +44,13 @@
 
     assert table.feature_names == names
 
+    if k < mx:
+        assert summary.f_statistic_ > 0
+        assert 0 <= summary.f_p_value_ <= 1
+
+    assert summary.j_statistic_ > 0
+    assert 0 <= summary.j_p_value_ <= 1
+
     summary_string = str(summary)
     for name in names:
         assert name in summary_string