fix: task hash

mlr-org · Nov 5, 2024 · 80c92da · 80c92da
1 parent ea53d4a
commit 80c92da
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/R/helper_hashes.R b/R/helper_hashes.R
@@ -46,6 +46,7 @@ task_hash = function(task, use_ids, test_ids = NULL, ignore_internal_valid_task
     task$backend$hash,
     task$col_info,
     use_ids,
+    task$col_roles,
     get_private(task)$.properties,
     internal_valid_task_hash)
 }
diff --git a/tests/testthat/test_Task.R b/tests/testthat/test_Task.R
@@ -661,3 +661,11 @@ test_that("cbind supports non-standard primary key (#961)", {
   task$cbind(data.table(x1 = 10:1))
   expect_true("x1" %in% task$feature_names)
 })
+
+test_that("$select changes hash", {
+  task = tsk("iris")
+  h1 = task$hash
+  task$select("Petal.Length")
+  h2 = task$hash
+  expect_false(h1 == h2)
+})