support running outside of its own directory #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all files were read/write from the current dir and assumed the script was run in that manner. when run in a different context it failed. this patch adds the base file path to all open() methods.
|
This looks good! Thanks for that. |
|
@krmaxwell LMK if you want to chime in |
|
Hi, @jfalken . Can you please send an e-mail to alexcp -at- mlsecproject -dot- org so I can send you a link to sign our CLA? |
|
What is a CLA? |
|
It's a Contributor License Agreement - https://en.wikipedia.org/wiki/Contributor_License_Agreement It pretty much says that you are ok in "donating" this code for us to be able to keep it open-source for all, and that you are not responsible for it any way, or to continue to provide support to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all files were read/write from the current dir and assumed the script
was run in that manner. when run in a different context (or from a diff path) it failed. this
patch adds the base file path to all open() methods.