Use ADB to take screenshots of android devices #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ADB screenshots for android devices as discussed in #175
Main Changes:
adb_path&adb_device_idtoconfig.screenshotsEnvconfig.screenshotsEnvare set and if thedevice_typeis android. If that is the case it will attempt to take screenshots using adb. It will use FlutterDriver to take the screenshots if the adb method fails for whatever reason..adb.pngor.driver.pngso the image processor knows how to process them. (Add Navbar or not)This works well with my setup. If it works as well for everyone else we could maybe think about dropping FlutterDriver support for android devices. This would make it much easier to add new devices because we would no longer need to add a statusbar and navbar for every resolution. The only downside of this would be that demo mode requires android 6.0.