Two minor improvements - quiet variable and using stderr#80
Open
straxhaber wants to merge 2 commits intommohades:masterfrom
Open
Two minor improvements - quiet variable and using stderr#80straxhaber wants to merge 2 commits intommohades:masterfrom
quiet variable and using stderr#80straxhaber wants to merge 2 commits intommohades:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quiet Variable
The quiet variable, in particular, is important when being used as a library. Users might not want to see so much content. The 2FA OTP is the one thing that always needs to be shown. By default, I left the verbosity as-is, and just added a command-line flag to turn it off.
stderr
Right now, most regular output is going to stdout. Status updates intended for the user should go to stderr rather than stdout. stdout should be for actual data that was returned by an intended command, not these status update messages.