a maintainership transfer request masquerading as a PR#94
Open
joshhubert-dsp wants to merge 24 commits intommohades:masterfrom
Open
a maintainership transfer request masquerading as a PR#94joshhubert-dsp wants to merge 24 commits intommohades:masterfrom
joshhubert-dsp wants to merge 24 commits intommohades:masterfrom
Conversation
…d some adjustment and may need to add in the models, but it should be usable to grab the token for payments
…s array inside the eligibility token object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mmohades,
I forked @j027's fork of your repo and significantly updated it, with the initial purpose of fixing payments. But I got a little carried away... and now I'm asking your permission to take over maintainership and create a new PyPi package, either with the same name or a different one, whichever you're comfortable with.
FORK UPDATES (copied from updated README)
adding eligibility token support and laying the groundwork.
PaymentApi.get_transfer_destinations()andPaymentApi.initiate_transfer()for standard/instant transfers to bank/card.
uvfriendly) and modern languagefeatures.
pydantic-v2, removing a bunch of boilerplate.LOGGING_SESSIONto print the raw requests sent and responsesreceived.
venmo.Clienthas context manager dunder methods forwithblock logout using astored access token.
that I didn't see as useful. In my experience Venmo is now quick to pump the brakes
on anyone hitting the API too rapidly. This manifests in the dreaded 403 response:
"OAuth2 Exception: Unable to complete your request. Please try again later", locking
you out of your account with a variable cooldown time.
headers live in
default_headers.json.Let me know if this works for you, or if there's anything else I should do. Currently I credit you and @j027 as authors in the pyproject. I'll update the Sphinx docs if/when I get your blessing.