Skip to content

a maintainership transfer request masquerading as a PR#94

Open
joshhubert-dsp wants to merge 24 commits intommohades:masterfrom
joshhubert-dsp:main
Open

a maintainership transfer request masquerading as a PR#94
joshhubert-dsp wants to merge 24 commits intommohades:masterfrom
joshhubert-dsp:main

Conversation

@joshhubert-dsp
Copy link

Hi @mmohades,
I forked @j027's fork of your repo and significantly updated it, with the initial purpose of fixing payments. But I got a little carried away... and now I'm asking your permission to take over maintainership and create a new PyPi package, either with the same name or a different one, whichever you're comfortable with.

FORK UPDATES (copied from updated README)

  • Payments work again! Credit to Joseph Charles for
    adding eligibility token support and laying the groundwork.
  • Added PaymentApi.get_transfer_destinations() and PaymentApi.initiate_transfer()
    for standard/instant transfers to bank/card.
  • Requires Python 3.11+, using a pyproject.toml (uv friendly) and modern language
    features.
  • The data models now use pydantic-v2, removing a bunch of boilerplate.
  • Set the env var LOGGING_SESSION to print the raw requests sent and responses
    received.
  • venmo.Client has context manager dunder methods for with block logout using a
    stored access token.
  • I got rid of the threaded-async callback functionality, because it added complexity
    that I didn't see as useful. In my experience Venmo is now quick to pump the brakes
    on anyone hitting the API too rapidly. This manifests in the dreaded 403 response:
    "OAuth2 Exception: Unable to complete your request. Please try again later", locking
    you out of your account with a variable cooldown time.
  • Request headers now mirror the actual app's as closely as possible. The default
    headers live in default_headers.json.
  • All code docstrings have been updated with changes.

Let me know if this works for you, or if there's anything else I should do. Currently I credit you and @j027 as authors in the pyproject. I'll update the Sphinx docs if/when I get your blessing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants