allocator: reduce cyclomatic complexity

Signed-off-by: Sebastiaan van Stijn <[email protected]>

manager/allocator/network.go

@@ -1057,24 +1057,22 @@ func (a *Allocator) allocateNode(ctx context.Context, node *api.Node, existingAd
 		if _, ok := nwIDs[na.Network.ID]; ok {
 			// attachment belongs to one of the networks, so keep it
 			attachments = append(attachments, na)
-		} else {
-			// free the attachment and remove it from the node's attachments by
-			// re-slicing
-			if err := a.netCtx.nwkAllocator.DeallocateAttachment(node, na); err != nil {
-				// if deallocation fails, there's nothing we can do besides log
-				// an error and keep going
-				log.G(ctx).WithError(err).Errorf(
-					"error deallocating attachment for network %v on node %v",
-					na.Network.ID, node.ID,
-				)
-			}
-			// strictly speaking, nothing was allocated, but something was
-			// deallocated and that counts.
-			allocated = true
-			// also, set the somethingWasDeallocated flag so the allocator
-			// knows that it can now try again.
-			a.netCtx.somethingWasDeallocated = true
+			continue
+		}
+
+		if err := a.netCtx.nwkAllocator.DeallocateAttachment(node, na); err != nil {
+			// failed to deallocate; there's nothing we can do besides log an error and keep going
+			log.G(ctx).WithError(err).Errorf("error deallocating attachment for network %v on node %v",
+				na.Network.ID, node.ID)
 		}
+
+		// strictly speaking, nothing was allocated, but something was
+		// deallocated and that counts.
+		allocated = true
+
+		// also, set the somethingWasDeallocated flag so the allocator
+		// knows that it can now try again.
+		a.netCtx.somethingWasDeallocated = true
 	}
 	node.Attachments = attachments