Skip to content

vendor: github.com/container-storage-interface/spec v1.10.0 - #3245

Open
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_csi
Open

vendor: github.com/container-storage-interface/spec v1.10.0#3245
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_csi

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Updating to the lowest release with container-storage-interface@abf6346, which removed use of the github.com/golang/protobuf aliases (deprecated).

- What I did

- How I did it

- How to test it

- Description for the changelog

@thaJeztah

Copy link
Copy Markdown
Member Author
# github.com/moby/swarmkit/v2/manager/csi [github.com/moby/swarmkit/v2/manager/csi.test]
manager/csi/plugin_test.go:63:65: cannot use controller (variable of type *fakeControllerClient) as "github.com/container-storage-interface/spec/lib/go/csi".ControllerClient value in argument to newPluginFromClients: *fakeControllerClient does not implement "github.com/container-storage-interface/spec/lib/go/csi".ControllerClient (missing method ControllerGetVolume)

@thaJeztah
thaJeztah marked this pull request as draft June 9, 2026 16:55
@thaJeztah

Copy link
Copy Markdown
Member Author

Hm... right; needs some changes;

# github.com/moby/swarmkit/v2/manager/csi [github.com/moby/swarmkit/v2/manager/csi.test]
manager/csi/plugin_test.go:63:65: cannot use controller (variable of type *fakeControllerClient) as "github.com/container-storage-interface/spec/lib/go/csi".ControllerClient value in argument to newPluginFromClients: *fakeControllerClient does not implement "github.com/container-storage-interface/spec/lib/go/csi".ControllerClient (missing method ControllerGetVolume)
FAIL	github.com/moby/swarmkit/v2/manager/csi [build failed]
FAIL

@codecov-commenter

codecov-commenter commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.69%. Comparing base (5a92899) to head (f8ecff7).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   14.76%   14.69%   -0.07%     
==========================================
  Files         200      198       -2     
  Lines       93027    93035       +8     
==========================================
- Hits        13736    13674      -62     
- Misses      77961    78012      +51     
- Partials     1330     1349      +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztah force-pushed the bump_csi branch 2 times, most recently from 6b0a7fe to a329cda Compare August 4, 2026 12:43
@thaJeztah
thaJeztah marked this pull request as ready for review August 4, 2026 12:45
Updating to the lowest release with [container-storage-interface@abf6346],
which removed use of the github.com/golang/protobuf aliases (deprecated).

[container-storage-interface@abf6346]: container-storage-interface/spec@abf6346

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants