Skip to content

Initialize CSI client before checking publish capability #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toughlex-donatas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Initialize CSI client before checking publish capability #3276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f47e9
Update plugin.go
toughlex-donatas Jul 31, 2026
e765da7
Merge branch 'moby:master' into patch-2
toughlex-donatas Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions manager/csi/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ func (p *plugin) DeleteVolume(ctx context.Context, v *api.Volume) error {
// the Node with the given swarmkit ID. It returns a map, which is the
// PublishContext for this Volume on this Node.
func (p *plugin) PublishVolume(ctx context.Context, v *api.Volume, nodeID string) (map[string]string, error) {
c, err := p.Client(ctx)
if err != nil {
return nil, err
}

if !p.publisher {
return nil, nil
}
Comment on lines +211 to 218
Expand All @@ -218,10 +223,6 @@ func (p *plugin) PublishVolume(ctx context.Context, v *api.Volume, nodeID string
}

req := p.makeControllerPublishVolumeRequest(v, nodeID)
c, err := p.Client(ctx)
if err != nil {
return nil, err
}
resp, err := c.ControllerPublishVolume(ctx, req)

if err != nil {
Expand All @@ -234,15 +235,16 @@ func (p *plugin) PublishVolume(ctx context.Context, v *api.Volume, nodeID string
// Volume from the Node with the given swarmkit ID. It returns an error if the
// unpublish does not succeed
func (p *plugin) UnpublishVolume(ctx context.Context, v *api.Volume, nodeID string) error {
c, err := p.Client(ctx)
if err != nil {
return err
}

if !p.publisher {
return nil
}

req := p.makeControllerUnpublishVolumeRequest(v, nodeID)
c, err := p.Client(ctx)
if err != nil {
return err
}

// response of the RPC intentionally left blank
_, err = c.ControllerUnpublishVolume(ctx, req)
Expand Down
Loading