Skip to content

POC: async fixtures support w/ pytest-asyncio - #59

Merged
freider merged 4 commits into
mainfrom
freider/async-fixtures
Jan 30, 2026
Merged

POC: async fixtures support w/ pytest-asyncio#59
freider merged 4 commits into
mainfrom
freider/async-fixtures

Conversation

@freider

@freider freider commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Turns out this works out of the box on pytest-asyncio 1.1+ so maybe we don't actually have to add the backward compatible hacks here. Still the tests are useful

@freider

freider commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

@prbot approve @mwaskom

@modal-pr-review-automation modal-pr-review-automation Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@freider
freider merged commit 69c23d5 into main Jan 30, 2026
8 checks passed
@freider
freider deleted the freider/async-fixtures branch January 30, 2026 11:07

@mwaskom mwaskom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants