Support progress notifications with McpClientTool and McpClientExtensions.CallToolAsync #312
+174
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions.CallToolAsync
LuisM000
reviewed
Apr 15, 2025
halter73
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
I think allowing you to pass in a progressTokenFactory or something similar to WithProgress along the lines of what @LuisM000 suggests could be interesting, but the scenario does seem pretty niche, and that could be added later.
PederHP
approved these changes
Apr 16, 2025
stephentoub
merged commit 227f440
into
modelcontextprotocol:main
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191