Flow ExecutionContext with JsonRpcMessage #616
+61
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary goal of this change is to support IHttpContextAccessor in tool calls when the Streamable HTTP is in its default non-Stateless mode.
| @@ -38,6 +39,19 @@ private protected JsonRpcMessage() | |||
| [JsonIgnore] | |||
| public ITransport? RelatedTransport { get; set; } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Not related to this immediate change, but it feels kind of strange that we're attaching a whole bunch of state to what is otherwise just a model for a protocol message. It does suggest that in the future we might want to refactor things somewhat, either by forcing separation between "domain models" and protocol version specific DTOs or perhaps by passing a context object alongside messages.
eiriktsarpalis
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this change is to support IHttpContextAccessor in tool calls when the Streamable HTTP is in its default non-Stateless mode.
I'm not 100% sure making
PerSessionExecutionContextconfigurable is the right move, but I have previously written sample code and tests that demonstrated the ability to set an AsyncLocal at the start of theRunSessionHandlercallback and use that inside of tool call handlers, and I figured that could still be useful. I don't see any easy workaround to get the same functionality without providing this option, but I'm open to alternatives or for a better name.Fixes #365.