Improve code readability and reduce potential string comparison errors on ElicitResult #666
+223
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…potential string comparison errors
stephentoub
reviewed
Aug 1, 2025
| { | ||
| Throw.IfNull(result); | ||
| return string.Equals(result.Action, "cancel", StringComparison.OrdinalIgnoreCase); | ||
| } |
There was a problem hiding this comment.
If we want to do this, why not have them as JsonIgnore properties directly on ElicitResult?
There was a problem hiding this comment.
Great point. While I was writing SupportsElicitation method, I biased to use extension method. Having properties with JsonIgnore would makes more sense. I'll refactor it.
There was a problem hiding this comment.
@stephentoub I've completed refactoring with your eye-opening question. Do you think this PR contributes to developer experience and you'd like to see it in the SDK?
There was a problem hiding this comment.
Thanks. We'll discuss it.
dogukandemir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has following additions on IMcpServer and ElicitResult.
Motivation and Context
Motivation is to make code more readable and less error-prone than direct string comparisons.
How Has This Been Tested?
All newly added functionality tested in unit tests.
Breaking Changes
There is no breaking change.
Types of changes
Checklist
Additional context