Decouple Handlers and Collections from protocol types #765
+1,311
−1,349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozkee
commented
Sep 11, 2025
…ion) from Capabilities by promoting them to the options types. Also, group all handlers in container classes, for server, I decided to move McpServerHandlers down to Mcp.Core and move the NotificationHandlers there too.
jozkee
force-pushed
the
capabilities4
branch
from
78218a4 to
82b62cf
Compare
| }, | ||
| }; | ||
|
|
||
| options.Handlers.ListToolsHandler = (request, cancellationToken) => |
There was a problem hiding this comment.
Not being able to set a handler within the object expression seems to me like a regression from a usability perspective. If decoupling handlers from the capability types is essential, consider using a structure that doesn't force this pattern (e.g. putting all handler properties on the ServerCapabilities type itself).
There was a problem hiding this comment.
That could be enabled by adding a setter to McpServerOptions.Handlers.
I thought of having Handlers initialized by default to avoid the null-terminating operator in cases like Handlers?.ListToolsHandler. We could still achieve both if we make that the setter disallows null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple Handlers and Collections (e.g. ToolsHandler and ToolsCollection) from Capabilities by promoting them to the options types.
Also, group all handlers in container classes, for server, I decided to move McpServerHandlers down to Mcp.Core and move the NotificationHandlers there too.