-
Notifications
You must be signed in to change notification settings - Fork 511
Implement SEP-973: Icons and metadata support for Implementations, Resources, Tools, and Prompts #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-753
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MackinnonBuck 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: MackinnonBuck <[email protected]>
… Resource, Tool, and Prompt Co-authored-by: MackinnonBuck <[email protected]>
…onsistency Co-authored-by: MackinnonBuck <[email protected]>
Copilot finished work on behalf of
MackinnonBuck
September 19, 2025 21:31
tests/ModelContextProtocol.Tests/Protocol/ImplementationTests.cs
Outdated
Show resolved
Hide resolved
tests/ModelContextProtocol.Tests/Protocol/ResourceAndPromptIconTests.cs
Outdated
Show resolved
Hide resolved
…files Co-authored-by: MackinnonBuck <[email protected]>
Copilot finished work on behalf of
MackinnonBuck
September 19, 2025 22:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEP-973: Icons and metadata support implementation
This PR implements SEP-973 which adds support for icons and additional metadata for Implementations, Resources, Tools, and Prompts.
Implementation Plan
Recent Changes (Addressing Code Review Feedback)
SEP-973-IMPLEMENTATION.md
andSEP-973-EXAMPLES.md
as they shouldn't be checked inResourceTests.cs
,PromptTests.cs
)ToolIconTests
toToolTests
and made tests less icon-centricKey Changes Implemented
1. New Icon Class (
Icon.cs
)Src
property for URI pointing to icon resourceMimeType
andSizes
properties2. Enhanced Classes with Icon Support
Icons
andWebsiteUrl
propertiesIcons
propertyIcons
propertyIcons
property3. Specification Compliance
✅ Matches TypeScript schema exactly
✅ Correct JSON property names (
icons
,websiteUrl
,src
,mimeType
,sizes
)✅ All new properties are optional for backward compatibility
✅ Supports multiple icons per entity
✅ Documents required (PNG, JPEG) and recommended (SVG, WebP) MIME types
✅ Includes security considerations for SVG and URI validation
4. Comprehensive Test Coverage
IconTests.cs
: Icon serialization, round-trip validation, and JsonException testsImplementationTests.cs
: Full Implementation testing with required property validationToolTests.cs
: Tool functionality testing including new icon supportResourceTests.cs
: Resource serialization and property validationPromptTests.cs
: Prompt functionality testingTechnical Details
IList<Icon>?
for consistency with existing collection patternsJsonPropertyName
attributesSecurity Features
Implementation includes documentation for:
Note: Build validation requires .NET 9 SDK. The implementation follows established patterns and should compile correctly with the appropriate SDK version.
Fixes #753.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.