Skip to content

Use Last-Event-ID instead of last-event-id #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Aug 5, 2025

@chemicL
Copy link
Member

chemicL commented Aug 5, 2025

https://www.rfc-editor.org/rfc/rfc9110.html#section-5.1

Field names are case-insensitive and ought to be registered within the "Hypertext Transfer Protocol (HTTP) Field Name Registry"

If this is causing any issues when the server provides lowercase or the client is unable to work with various cases then please open an issue with a reproducer so we can investigate and address it properly.

@tzolov tzolov added bug Something isn't working and removed bug Something isn't working labels Aug 5, 2025
@tzolov
Copy link
Contributor

tzolov commented Aug 5, 2025

@chemicL , a good point but better to play "safe". Most SDK implementations likely aren't case insensitive - Seems like the Java SDK is not either.

Correction: The Java SDK handles the case insensitive as expected as it relies on the Java/Spring API for header management.

@quaff
Copy link
Contributor Author

quaff commented Aug 6, 2025

https://www.rfc-editor.org/rfc/rfc9110.html#section-5.1

Field names are case-insensitive and ought to be registered within the "Hypertext Transfer Protocol (HTTP) Field Name Registry"

If this is causing any issues when the server provides lowercase or the client is unable to work with various cases then please open an issue with a reproducer so we can investigate and address it properly.

I'm not saying it will cause any issue, I think it's better to align with SSE spec and MCP-Protocol-Version in the same source file.

@tzolov tzolov merged commit 7f37ddc into modelcontextprotocol:main Aug 6, 2025
1 of 2 checks passed
@tzolov
Copy link
Contributor

tzolov commented Aug 6, 2025

back-ported to 0.11.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants