Skip to content

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 16, 2025

This change extracts classes previously in mcp to mcp-core; a new module which does not depend on mcp-json-jackon2.

mcp module is now an umbrella module that brings mcp-json-jackon2 and mcp-core

Motivation and Context

The motivation is to have a mcp-core module which is free of Jackson dependencies.

How Has This Been Tested?

This PR only relocated sources. I have run p ./mvnw clean install -DskipTests and ./mvnw test.

Breaking Changes

mcp dependency still contains mcp-core and mcp-json-jackson2. However, the classes will be in a different JAR. Thus, this can be considered a breaking change.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/Publishing

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

This change extracts classes previously in `mcp` to `mcp-core`; a new module which does not depend on `mcp-json-jackon2`.

`mcp` module is now an umbrella module that brings `mcp-json-jackon2` and `mcp-core`
@sdelamo
Copy link
Contributor Author

sdelamo commented Sep 16, 2025

@tzolov, could you check the different pom.xml in mcp-json, mcp-json-jackson2, mcp, and mcp-core and ensure the configuration of the bnd-maven-plugin and maven-jar-plugin is correct?

I don't have experience with the publication settings of the project, and I fear I have misconfigured those plugins.

@tzolov tzolov self-assigned this Sep 16, 2025
@tzolov tzolov added this to the 0.13.0 milestone Sep 16, 2025
Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdelamo!
The changes look good and align with our previous discussion. The Maven plugins also look good to me.

@tzolov tzolov merged commit 1499df2 into modelcontextprotocol:main Sep 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants