Skip to content

Fix deserialization in read buffer #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Fix deserialization in read buffer #225

merged 2 commits into from
Aug 19, 2025

Conversation

tiginamaria
Copy link
Contributor

@tiginamaria tiginamaria commented Aug 15, 2025

Wrap message deserialization into try catch to avoid exceptions what stdio server outputs plain text

Motivation and Context

This issue was reported in Koog when the user tried to redirected errors to the output
JetBrains/koog#251

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link

@skarpovdev skarpovdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick fix!

@devcrocod devcrocod force-pushed the tigina/read-buffer-fix branch from a7a041d to ee22eb9 Compare August 19, 2025 16:14
Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devcrocod devcrocod merged commit 9bb851a into main Aug 19, 2025
4 of 5 checks passed
@devcrocod devcrocod deleted the tigina/read-buffer-fix branch August 19, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants