Skip to content

Conversation

kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Sep 15, 2025

Update build workflow: refine report handling and add test result publishing

  • Change Upload Reports to run only when not cancelled.
  • Add a new step to publish test results with a detailed summary.

Motivation and Context

The test report should be easy to find

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@kpavlov kpavlov force-pushed the kpavlov/test-report branch from fb2a80f to 2c047c0 Compare September 15, 2025 18:14
@kpavlov kpavlov changed the title Publich test report Publish test report Sep 15, 2025
@kpavlov kpavlov changed the title Publish test report Generate test report Sep 15, 2025
@kpavlov kpavlov added the tests label Sep 15, 2025
@kpavlov kpavlov force-pushed the kpavlov/test-report branch from 2c047c0 to 9407e5e Compare September 15, 2025 18:25
@kpavlov kpavlov marked this pull request as ready for review September 15, 2025 18:26
Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -37,13 +37,24 @@ jobs:
JAVA_OPTS: "-Xmx8g -Dfile.encoding=UTF-8 -Djava.awt.headless=true -Dkotlin.daemon.jvm.options=-Xmx6g"

- name: Upload Reports
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument for keeping it - there was a case when our tests that use JUnit5 weren't running because of the misconfiguraion, so we didn't know which tests are run and which are not.
Not a strong opinion so if there are any downsides in having it, let's switch to ${{ !cancelled() }} indeed.

…lishing

- Change `Upload Reports` to run only when not cancelled.
- Add a new step to publish test results with a detailed summary.
@kpavlov kpavlov force-pushed the kpavlov/test-report branch from 1b02e4c to 26697b4 Compare September 16, 2025 04:51
@kpavlov kpavlov merged commit 1397019 into main Sep 16, 2025
4 checks passed
@kpavlov kpavlov deleted the kpavlov/test-report branch September 16, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants