Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #56 - missing method attribute from client RPC message #58

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomakehurst
Copy link

Motivation and Context

Per #56 Cursor (and apparently some other MCP clients) don't send the method attribute in the params map in their notification messages, whereas this server requires it to be present, throwing an NPE when it's not and thus preventing successful initialisation.

How Has This Been Tested?

Tested manually with the latest version of Cursor - 0.46.8

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Draft at present, as automating a test will require modifying the client code (or pulling in an alternative client) to behave like Cursor and others.

Sorry, something went wrong.

@tomakehurst
Copy link
Author

This probably isn't the cleanest way to implement this fix, but better options will probably require some more invasive surgery on the codebase.

@tomakehurst tomakehurst changed the title Fixe for #56 - missing method attribute from client RPC message Fix for #56 - missing method attribute from client RPC message Mar 20, 2025
@e5l e5l self-requested a review March 25, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant