Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support consumers that require Java 8 #60

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Leland-Takamine
Copy link
Contributor

Update target to Java 8

Motivation and Context

Support consumers that are compiling against Java 8

How Has This Been Tested?

Ensured that the build succeeds

Breaking Changes

No known breaking changes

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@Leland-Takamine
Copy link
Contributor Author

@e5l Curious if this is something you'd be open to merging?

@Leland-Takamine
Copy link
Contributor Author

We're trying to embed an MCP server into our codebase which has target compatibility set to Java 8 for Reasons™️, and it would be difficult for us to change that.

@e5l
Copy link
Contributor

e5l commented Mar 25, 2025

yep, looks good

@e5l e5l self-requested a review March 25, 2025 19:36
@Leland-Takamine
Copy link
Contributor Author

Thanks! Curious if you all plan to do a release any time soon?

@e5l
Copy link
Contributor

e5l commented Mar 25, 2025

I'm going to check the open PRs tomorrow, merge greens and trigger the release

@Leland-Takamine
Copy link
Contributor Author

Sweet thanks again!

@e5l e5l enabled auto-merge (squash) March 26, 2025 08:19
@e5l e5l merged commit b0532d9 into modelcontextprotocol:main Mar 26, 2025
1 check passed
@Leland-Takamine Leland-Takamine deleted the java8 branch March 27, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants