Skip to content

feat: Add audio type according to 2025-03-26 spec #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SeanChinJunKai
Copy link
Contributor

Motivation and Context

This PR provides added support for audio data

How Has This Been Tested?

NA

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

References: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-03-26/schema.ts#L990

@e5l e5l requested review from Copilot and e5l April 9, 2025 18:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.kt:886

  • The documentation for PromptMessageContentMultimodal should be updated to reflect that it now supports audio content in addition to text and image.
 * Represents prompt message content that is either text or an image.

src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/types.kt:932

  • AudioContent is a new functionality that currently lacks test coverage; please add appropriate tests to verify its behavior.
 * Audio provided to or from an LLM.

@SeanChinJunKai
Copy link
Contributor Author

@e5l I missed updating the documentation let me make the change

Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test?

@SeanChinJunKai
Copy link
Contributor Author

Hi @e5l, I will look into it

@SeanChinJunKai
Copy link
Contributor Author

Hi @e5l, have added a unit test for this PR. Im planning to add more unit tests in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants