-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[DO NOT MERGE] Implement RFC 7523 JWT flows #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LucaButBoring
wants to merge
30
commits into
modelcontextprotocol:main
Choose a base branch
from
LucaButBoring:feat/rfc7523
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DO NOT MERGE] Implement RFC 7523 JWT flows #1247
LucaButBoring
wants to merge
30
commits into
modelcontextprotocol:main
from
LucaButBoring:feat/rfc7523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20b5dfc.
…-sdk into feat/client-credentials
…-sdk into feat/client-credentials
…-sdk into feat/client-credentials
No longer doing external integration examples as of modelcontextprotocol#1011. Will likely bring this back later as a standalone example.
Python default parameters reuse their references, so we can't use a collection like a dict as a default parameter value or we'll dirty our state.
Does it means that at the client creation, we have to select a different class? |
Yes, that's what I inferred from @ochafik's statement on #1020:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for the RFC 7523 authentication flows. This PR is a trimmed-down version of #1020, but will likely be superceded by a future
authlib
-based implementation (see #1240).Compared to #1020, this implements the flow via a separate
httpx.Auth
subclass, which is in-line with prior maintainer feedback on how to grow these auth implementations.Motivation and Context
Implementation example for modelcontextprotocol/modelcontextprotocol#1046.
How Has This Been Tested?
Unit tests (TBD: unit tests for section 2.2 flow). Planning to spot test with Keycloak setup once that gets published.
Breaking Changes
None.
Types of changes
Checklist
Additional context