Skip to content

Propagate Custom Request ID to use in cancel notification for call tool and get prompt #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Feb 24, 2025

Propagate Custom Request ID so that it can be used in cancel notification. The convention is that any Custom Request ID is a string, and int is for automatically incremented request IDs.

Motivation and Context

(#230)

How Has This Been Tested?

NA

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@ihrpr
Copy link
Contributor Author

ihrpr commented Feb 27, 2025

Closing as we discussed a better approach to solve it

@ihrpr ihrpr closed this Feb 27, 2025
@dsp-ant
Copy link
Member

dsp-ant commented Feb 28, 2025

We could keep it open and continue using this PR. But feel free to do it however you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants