feat: support embedded resources in sampling #727
Draft
+54
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
added
pending publish
|
Marking this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates sampling to support embedded resources in requests and responses.
Motivation and Context
Brings sampling to parity with tool calls in terms of supported message types. This PR is intended to support modelcontextprotocol/modelcontextprotocol#522.
How Has This Been Tested?
Updated integration tests to include an embedded resource test.
Breaking Changes
None.
Types of changes
Checklist
Additional context
This PR will be updated accordingly if #725 is merged before this.