Skip to content

Conversation

slimslenderslacks
Copy link
Contributor

When using mcp-publisher publish ..., output the new server ID if publishing is successful.

Motivation and Context

It's useful to know this during testing. It means that you don't have to go and search for the new server ID afterwards. Once we have the v0/servers/{name}/{version}, I think we could consider removing this again.

How Has This Been Tested?

I've been using this while I test publishing to locally running registries.

Breaking Changes

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Collaborator

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions so we can keep the function return behaviour the same 👍

Copy link
Collaborator

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks, @slimslenderslacks! 🙏

rdimitrov
rdimitrov previously approved these changes Sep 9, 2025
Copy link
Collaborator

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rdimitrov
Copy link
Collaborator

This would also address - #401

@rdimitrov
Copy link
Collaborator

@slimslenderslacks - hey, Jim, there are some conflicts with the latest main, can you rebase your changes? Thanks! 👍

@slimslenderslacks
Copy link
Contributor Author

slimslenderslacks commented Sep 9, 2025

@rdimitrov I just rebased.

@domdomegg domdomegg merged commit ca3da90 into modelcontextprotocol:main Sep 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants