-
Notifications
You must be signed in to change notification settings - Fork 295
output new ServerID after publishing #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output new ServerID after publishing #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions so we can keep the function return behaviour the same 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks, @slimslenderslacks! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
This would also address - #401 |
@slimslenderslacks - hey, Jim, there are some conflicts with the latest main, can you rebase your changes? Thanks! 👍 |
bfb8b1a
to
21d566b
Compare
@rdimitrov I just rebased. |
When using
mcp-publisher publish ...
, output the new serverID
if publishing is successful.Motivation and Context
It's useful to know this during testing. It means that you don't have to go and search for the new server ID afterwards. Once we have the
v0/servers/{name}/{version}
, I think we could consider removing this again.How Has This Been Tested?
I've been using this while I test publishing to locally running registries.
Breaking Changes
none
Types of changes
Checklist