Skip to content

Conversation

@nbarbettini
Copy link
Contributor

Motivation and Context

Reacting to upstream schema changes. Discussion: modelcontextprotocol/modelcontextprotocol#1863 (comment)

How Has This Been Tested?

Existing test coverage plus 1 new test.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

A few review comments inline, below.

@nbarbettini nbarbettini requested a review from a team as a code owner November 21, 2025 22:13
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@1154

commit: bf5fbd1

@nbarbettini nbarbettini changed the title Elicitation/back compat request fix: React to upstream RC schema changes for form mode elicitation requests Nov 21, 2025
@KKonstantinov
Copy link
Contributor

LGTM!

One comment is on the cherry picked spec types, but we probably have no choice and it will be just temporary until the tasks SEP gets finalized on TS SDK and merged.

@felixweinberger
Copy link
Contributor

felixweinberger commented Nov 23, 2025

Thanks for updating the PR! Please merge at your convenience :)

@felixweinberger felixweinberger enabled auto-merge (squash) November 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants