Skip to content

fix: prevent streamable http wite after end from crashing the node process #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
+15 −0
Merged

fix: prevent streamable http wite after end from crashing the node process #933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf794de
fix: prevent streamable http wite after end crashing the node process
MQ37 Sep 11, 2025
6915701
Merge branch 'main' into fix/write-after-end
MQ37 Sep 15, 2025
dea1ecc
simplify the fix
MQ37 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/server/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,11 @@ export class StreamableHTTPServerTransport implements Transport {
res.on("close", () => {
this._streamMapping.delete(this._standaloneSseStreamId);
});

// Add error handler for standalone SSE stream
res.on("error", (error) => {
this.onerror?.(error as Error);
});
}

/**
Expand Down Expand Up @@ -334,6 +339,11 @@ export class StreamableHTTPServerTransport implements Transport {
}
});
this._streamMapping.set(streamId, res);

// Add error handler for replay stream
res.on("error", (error) => {
this.onerror?.(error as Error);
});
} catch (error) {
this.onerror?.(error as Error);
}
Expand Down Expand Up @@ -520,6 +530,11 @@ export class StreamableHTTPServerTransport implements Transport {
this._streamMapping.delete(streamId);
});

// Add error handler for stream write errors
res.on("error", (error) => {
this.onerror?.(error as Error);
});

// handle each message
for (const message of messages) {
this.onmessage?.(message, { authInfo, requestInfo });
Expand Down