-
Notifications
You must be signed in to change notification settings - Fork 171
Fix column layout in documentation of Modelica.Media.IdealGases.SingleGases #4588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Edited documentation from Modelica.Media.IdealGases.SingleGases
WalkthroughThe changes modify the documentation in the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Modelica/Media/IdealGases/SingleGases.mo (1)
366-366
: Documentation Table Formatting ImprovementThe revised preformatted gas list on line 366 now clearly separates entries so that “Neon” and “Oxygen” are distinct, enhancing readability. Please verify that the change correctly reflects the intended “fix” for compound names—if the goal was also to split “Nitrous Oxide” into “Nitrous” and “Oxide,” double-check that the formatting and spacing convey that clearly and that the total number of gases remains consistent with the expected 37.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Modelica/Media/IdealGases/SingleGases.mo
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: external_c_checks_cmake_windows-msvc
- GitHub Check: external_c_checks_cmake_windows-cygwin
Backported to maint/4.1.x by #4625 |
…eGases (#4588) (#4625) Co-authored-by: LéoSchmider <[email protected]> Co-authored-by: Nithish Selvan <[email protected]>
Edited documentation from Modelica.Media.IdealGases.SingleGases.mo
Summary by CodeRabbit