Add rotation and systemInnerRotation attributes - #133
Open
DagBruck wants to merge 39 commits into
Open
Conversation
|
Why would only the connector geometry get a "systemInnerRotation"? The element geometry has no "systemInnerRotation". Does it need one as well then? I think you missed the schema changes. |
pmai
reviewed
Jul 13, 2026
Tc-Fast
force-pushed
the
DagBruck-connrot
branch
from
July 27, 2026 11:18
dbd5759 to
5be946f
Compare
|
I have rebased on thorstens modelica_theme branch. |
|
I will add the schema images tomorrow |
Tc-Fast
force-pushed
the
DagBruck-connrot
branch
from
July 28, 2026 04:08
5be946f to
5d54c6b
Compare
Tc-Fast
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #132