Skip to content

Conversation

akaitsuki-ii
Copy link
Contributor

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @akaitsuki-ii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical fix for the WAN UMT5 state dictionary converter. The changes ensure that the model can accurately load and interpret weights from diffusers checkpoints by updating the parameter renaming logic and the mechanism for identifying the diffusers state dict format. This resolves potential issues with model initialization and ensures compatibility with external weight sources.

Highlights

  • State Dictionary Key Renaming: The mapping of state dictionary keys within the _from_diffusers method has been updated to correctly convert weights from a diffusers format to the internal model format. This includes changes for the token embedding, final normalization layer, and all individual encoder block parameters (attention, feed-forward networks, and layer norms).
  • Diffusers Format Detection Logic: The convert method's conditional check for identifying a diffusers formatted state dictionary has been modified. It now uses the key encoder.final_layer_norm.weight to detect the correct format, aligning with the updated key patterns.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the WanTextEncoderStateDictConverter by correcting the state dictionary key mappings for diffusers UMT5 models. The previous implementation used incorrect keys, which this PR rectifies within the _from_diffusers method. Additionally, the detection logic in the convert method has been updated to correctly identify the diffusers model format. These changes are accurate and effectively resolve the issue, ensuring proper model weight loading from diffusers checkpoints.

@akaitsuki-ii akaitsuki-ii merged commit e068d10 into main Sep 16, 2025
@akaitsuki-ii akaitsuki-ii deleted the fix/umt5 branch September 16, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants