Skip to content

Conversation

@w1ida
Copy link

@w1ida w1ida commented Dec 9, 2025

This PR adds optional Cut-Cross-Entropy (CCE) loss into the ms-swift training pipeline.
CCE is a memory-efficient alternative to standard CE, from Apple’s project:

➡️ https://github.com/apple/ml-cross-entropy


✨ Features

  • Add use_cce=True in TrainArguments to enable CCE.
  • Plug-and-play replacement; no model modification required.
  • Add test script: tests/train/test_cce.py.

Usage:

TrainArguments(
    model='Qwen/Qwen2.5-0.5B-Instruct',
    dataset=['gsm8k#1024'],
    split_dataset_ratio=0.01,
    use_cce=True,
    **kwargs
)

Install dependency:

pip install "cut-cross-entropy @ git+https://github.com/w1ida/ml-cross-entropy.git"

📊 Memory Result (A10, BS=64)

  • Hardware: NVIDIA A10
  • transformers: 4.56.1
  • Model: Qwen/Qwen2.5-0.5B-Instruct
  • Dataset: gsm8k#1024
  • Batch size: 64

Environment

  • Hardware: NVIDIA A10
  • transformers: 4.56.1
  • Model: Qwen/Qwen2.5-0.5B-Instruct
  • Dataset: gsm8k#1024
  • Batch size: 64

Memory Usage

Loss Memory (GiB)
transformers CE 16.24
CCE 2.62

≈ 84% memory reduction.


📄 Reference

Cut Your Losses in Large-Vocabulary Language Models
https://arxiv.org/abs/2411.09009

image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @w1ida, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Cut-Cross-Entropy (CCE) loss into the training pipeline, offering a significant memory optimization for large language models. By providing a memory-efficient alternative to traditional cross-entropy, it enables training of larger models or larger batch sizes on existing hardware, making the training process more accessible and scalable.

Highlights

  • Cut-Cross-Entropy (CCE) Integration: Introduced optional CCE loss into the training pipeline, a memory-efficient alternative to standard cross-entropy, based on Apple's ml-cross-entropy project.
  • Memory Efficiency: Demonstrated approximately 84% memory reduction on an NVIDIA A10 GPU for a Qwen model with a batch size of 64, significantly optimizing resource usage.
  • Ease of Use: CCE can be enabled by setting "use_cce=True" in "TrainArguments" and is designed as a plug-and-play replacement without requiring model modifications.
  • Model Support: The CCE patching mechanism supports various LLM architectures including Llama, Mistral, Phi3, Gemma2, and Qwen2.
  • Test Coverage: A new test script ("tests/train/test_cce.py") has been added to validate CCE functionality during SFT training, ensuring proper integration and operation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Cut-Cross-Entropy (CCE) loss, offering a memory-efficient alternative for training. The changes integrate CCE into the training pipeline, add UI elements for activation, and include a dedicated test script. The implementation generally follows existing patterns for kernel integrations, such as the Liger kernel, ensuring consistency. The UI updates are well-localized and clearly explain the new feature. Overall, this is a valuable addition for optimizing memory usage during training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants