-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[feat] Add Support Cut-Cross-Entropy (CCE) #6971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @w1ida, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Cut-Cross-Entropy (CCE) loss into the training pipeline, offering a significant memory optimization for large language models. By providing a memory-efficient alternative to traditional cross-entropy, it enables training of larger models or larger batch sizes on existing hardware, making the training process more accessible and scalable. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Cut-Cross-Entropy (CCE) loss, offering a memory-efficient alternative for training. The changes integrate CCE into the training pipeline, add UI elements for activation, and include a dedicated test script. The implementation generally follows existing patterns for kernel integrations, such as the Liger kernel, ensuring consistency. The UI updates are well-localized and clearly explain the new feature. Overall, this is a valuable addition for optimizing memory usage during training.
This PR adds optional Cut-Cross-Entropy (CCE) loss into the ms-swift training pipeline.
CCE is a memory-efficient alternative to standard CE, from Apple’s project:
➡️ https://github.com/apple/ml-cross-entropy
✨ Features
use_cce=TrueinTrainArgumentsto enable CCE.tests/train/test_cce.py.Usage:
Install dependency:
pip install "cut-cross-entropy @ git+https://github.com/w1ida/ml-cross-entropy.git"📊 Memory Result (A10, BS=64)
Qwen/Qwen2.5-0.5B-Instructgsm8k#1024Environment
Qwen/Qwen2.5-0.5B-Instructgsm8k#1024Memory Usage
≈ 84% memory reduction.
📄 Reference
Cut Your Losses in Large-Vocabulary Language Models
https://arxiv.org/abs/2411.09009