Fix MariaDB compatibility issue with multiple TIMESTAMP defaults#149
Closed
Copilot wants to merge 2 commits into
Closed
Fix MariaDB compatibility issue with multiple TIMESTAMP defaults#149Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: Mark-H <312944+Mark-H@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Incompatibility with MariaDB
Fix MariaDB compatibility issue with multiple TIMESTAMP defaults
Jul 8, 2025
Contributor
|
Theoretically this approach should work because if a default is not provided, MySQL/MariaDB should fallback to its own default which for timestamp should be the current time. In this case can probably remove the other default as well. Will test! |
Contributor
|
Fix in 0a65b02 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the MariaDB compatibility error when creating the
versionx_deltatable during installation.Problem
MariaDB enforces a restriction where only one TIMESTAMP column per table can have
CURRENT_TIMESTAMPin the DEFAULT or ON UPDATE clause. ThevxDeltatable definition had bothtime_startandtime_endfields configured withdefault="CURRENT_TIMESTAMP", causing this error:Solution
CURRENT_TIMESTAMPdefault from thetime_endfield in the XML schematime_startwith theCURRENT_TIMESTAMPdefault as the primary timestamp fieldImpact
time_startandtime_endwhen creating deltasThe fix ensures compatibility with MariaDB while maintaining the existing delta creation logic where both timestamps are set to the same value (
$now) by the application.Fixes #148.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.