fix(xsfetch): make retry
work, remove the exposure of retryCount
#88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've found an issue in xsfetch that
retry
does not take effect.Essentially it's
options.retry < options.retryCount
needs to beoptions.retry > options.retryCount
.It can be easily reproduced by the following code (you might add some debug logs in the retry logic to see that it is not executed):
This PR is fixing the issue and also performing a little bit refactoring that eliminates the need for exposing
retryCount
in the fetch options.